linux-kernel - Re: [PATCH] staging: rtl8712: Replace function r8712_free_network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190603121829.GA15705@kroah.com>
Date:   Mon, 3 Jun 2019 14:18:29 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Nishka Dasgupta <nishkadg.linux@...il.com>
Cc:     larry.finger@...inger.net, florian.c.schilhabel@...glemail.com,
        himadri18.07@...il.com, colin.king@...onical.com,
        straube.linux@...il.com, yangx92@...mail.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Replace function
 r8712_free_network_queue

On Fri, May 31, 2019 at 02:27:55AM +0530, Nishka Dasgupta wrote:
> Remove function r8712_free_network_queue as it does nothing except call
> _free_network_queue.
> Rename _free_network_queue to r8712_free_network_queue (and change its
> type to static) for continued use of the original functionality.

You did not change the type to static:

> -static void _free_network_queue(struct _adapter *padapter)
> +void r8712_free_network_queue(struct _adapter *padapter)

:(