linux-kernel - Re: [PATCH] staging: rtl8712: Change _SUCCESS/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190603122046.GA27037@kroah.com>
Date:   Mon, 3 Jun 2019 14:20:46 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Nishka Dasgupta <nishkadg.linux@...il.com>
Cc:     larry.finger@...inger.net, florian.c.schilhabel@...glemail.com,
        straube.linux@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Change _SUCCESS/_FAIL to 0/-ENOMEM

On Fri, May 31, 2019 at 02:36:38AM +0530, Nishka Dasgupta wrote:
> Change return values _SUCCESS and _FAIL to 0 and -ENOMEM respectively,
> to match the convention in the drivers (and also because the return
> value of this changed function is never checked anyway).
> Change return type of the function to int (from u8) to allow the return
> of -ENOMEM.
> 
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@...il.com>
> ---
>  drivers/staging/rtl8712/rtl871x_cmd.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Also does not apply to my tree :(