linux-kernel - Re: [PATCH] sched/core: add __sched tag for io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b95526a4-33cc-12df-020c-011d67ca797b@huawei.com>
Date:   Mon, 3 Jun 2019 12:25:02 +0800
From:   Gao Xiang <gaoxiang25@...wei.com>
To:     Tejun Heo <tj@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     Ingo Molnar <mingo@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "Peter Zijlstra" <peterz@...radead.org>, <stable@...r.kernel.org>,
        Miao Xie <miaoxie@...wei.com>, <koujilong@...wei.com>
Subject: Re: [PATCH] sched/core: add __sched tag for io_schedule()



On 2019/5/31 22:37, Tejun Heo wrote:
> On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote:
>> non-inline io_schedule() was introduced in
>> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
>> Keep in line with io_schedule_timeout, Otherwise
>> "/proc/<pid>/wchan" will report io_schedule()
>> rather than its callers when waiting io.
>>
>> Reported-by: Jilong Kou <koujilong@...wei.com>
>> Cc: Tejun Heo <tj@...nel.org>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
> 
> Acked-by: Tejun Heo <tj@...nel.org>

Cc: <stable@...r.kernel.org> # 4.11+

Thanks Tejun. This patch will be needed for io performance analysis
since we found that Android systrace tool cannot show the callers of
iowait raised from io_schedule() on linux-4.14 LTS kernel.

Hi Andrew, could you kindly take this patch?

Thanks,
Gao Xiang

> 
> Thanks.
>