linux-kernel - Re: [PATCH] kbuild: Remove -Waggregate-return from scripts/Makefile.extrawarn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Jun 2019 02:09:58 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: Remove -Waggregate-return from scripts/Makefile.extrawarn

On Wed, May 29, 2019 at 5:16 PM Mathieu Malaterre <malat@...ian.org> wrote:
>
> It makes little sense to pass -Waggregate-return these days since large
> part of the linux kernel rely on returning struct(s). For instance:
>
>   ../include/linux/timekeeping.h: In function 'show_uptime':
>   ../include/linux/ktime.h:91:34: error: function call has aggregate value [-Werror=aggregate-return]
>    #define ktime_to_timespec64(kt)  ns_to_timespec64((kt))
>                                     ^~~~~~~~~~~~~~~~~~~~~~
>   ../include/linux/timekeeping.h:166:8: note: in expansion of macro 'ktime_to_timespec64'
>     *ts = ktime_to_timespec64(ktime_get_coarse_boottime());
>
> Remove this warning from W=2 completely.
>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---

Applied to linux-kbuild. Thanks.



>  scripts/Makefile.extrawarn | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> index 3ab8d1a303cd..98081ab300e5 100644
> --- a/scripts/Makefile.extrawarn
> +++ b/scripts/Makefile.extrawarn
> @@ -34,7 +34,6 @@ warning-1 += $(call cc-option, -Wstringop-truncation)
>  warning-1 += -Wno-missing-field-initializers
>  warning-1 += -Wno-sign-compare
>
> -warning-2 := -Waggregate-return
>  warning-2 += -Wcast-align
>  warning-2 += -Wdisabled-optimization
>  warning-2 += -Wnested-externs
> --
> 2.20.1
>


-- 
Best Regards
Masahiro Yamada