[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190604175731.GB241153@google.com>
Date: Tue, 4 Jun 2019 10:57:31 -0700
From: Benson Leung <bleung@...gle.com>
To: Pi-Hsun Shih <pihsun@...omium.org>
Cc: Rob Herring <robh@...nel.org>, Lee Jones <lee.jones@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Benson Leung <bleung@...omium.org>,
Enric Balletbo i Serra <enric.balletbo@...labora.com>,
Guenter Roeck <groeck@...omium.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 5/7] dt-bindings: Add binding for cros-ec-rpmsg.
On Fri, May 31, 2019 at 03:38:46PM +0800, Pi-Hsun Shih wrote:
> Add a DT binding documentation for ChromeOS EC driver over rpmsg.
>
> Signed-off-by: Pi-Hsun Shih <pihsun@...omium.org>
> Acked-by: Rob Herring <robh@...nel.org>
Reviewed-by: Benson Leung <bleung@...omium.org>
>
> ---
> Changes from v8, v7, v6:
> - No change.
>
> Changes from v5:
> - New patch.
> ---
> Documentation/devicetree/bindings/mfd/cros-ec.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> index 6245c9b1a68b..4860eabd0f72 100644
> --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt
> +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> @@ -3,7 +3,7 @@ ChromeOS Embedded Controller
> Google's ChromeOS EC is a Cortex-M device which talks to the AP and
> implements various function such as keyboard and battery charging.
>
> -The EC can be connect through various means (I2C, SPI, LPC) and the
> +The EC can be connect through various means (I2C, SPI, LPC, RPMSG) and the
> compatible string used depends on the interface. Each connection method has
> its own driver which connects to the top level interface-agnostic EC driver.
> Other Linux driver (such as cros-ec-keyb for the matrix keyboard) connect to
> @@ -17,6 +17,9 @@ Required properties (SPI):
> - compatible: "google,cros-ec-spi"
> - reg: SPI chip select
>
> +Required properties (RPMSG):
> +- compatible: "google,cros-ec-rpmsg"
> +
> Optional properties (SPI):
> - google,cros-ec-spi-pre-delay: Some implementations of the EC need a little
> time to wake up from sleep before they can receive SPI transfers at a high
> --
> 2.22.0.rc1.257.g3120a18244-goog
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists