linux-kernel - Re: [PATCH 1/3] clocksource/arm_arch_timer: mark arch_counter_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f454508f-f6b6-48c3-539a-9c1776952f19@linaro.org>
Date:   Tue, 4 Jun 2019 07:52:08 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Marc Zyngier <marc.zyngier@....com>,
        Anders Roxell <anders.roxell@...aro.org>, mark.rutland@....com,
        tglx@...utronix.de
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        mingo@...hat.com
Subject: Re: [PATCH 1/3] clocksource/arm_arch_timer: mark arch_counter_get_*
 as notrace

Hi Anders,

thanks for your patch. As mentioned by Mark I already applied this fix
from Julien Thierry.

 -- Daniel


On 03/06/2019 11:23, Marc Zyngier wrote:
> Hi Anders,
> 
> 
> On 03/06/2019 10:12, Anders Roxell wrote:
>> When CONFIG_FUNCTION_GRAPH_TRACER is enabled we end up in this circular
>> call trace since function arch_counter_get_cntvct() isn't marked with no
>> trace:
>>
>> [   17.914934] Call trace:
>> [   17.915211]  ftrace_return_to_handler+0x194/0x288
>> [   17.915551]  return_to_handler+0x1c/0x38
>> [   17.915855]  trace_clock_local+0x38/0x88
>> [   17.916159]  function_graph_enter+0xf0/0x258
>> [   17.916465]  prepare_ftrace_return+0x60/0x90
>> [   17.916772]  ftrace_graph_caller+0x1c/0x24
>> [   17.917093]  arch_counter_get_cntvct+0x10/0x30
>> [   17.917417]  sched_clock+0x70/0x218
>> [   17.917723]  trace_clock_local+0x38/0x88
>> [   17.918026]  function_graph_enter+0xf0/0x258
>> [   17.918332]  prepare_ftrace_return+0x60/0x90
>> [   17.918649]  ftrace_graph_caller+0x1c/0x24
>> [   17.918963]  arch_counter_get_cntvct+0x10/0x30
>> [   17.919286]  sched_clock+0x70/0x218
>>
>> Rework so that function arch_counter_get_cntvct() is marked with notrace.
>>
>> Fixes: 0ea415390cd3 ("clocksource/arm_arch_timer: Use arch_timer_read_counter to access stable counters")
>> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> 
> This has already been queued by Daniel, I believe [1].
> 
> [1] https://lore.kernel.org/lkml/1558689025-50679-1-git-send-email-julien.thierry@arm.com/





-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog