linux-kernel - Re: [PATCH v3 net-next 04/17] net: dsa: sja1105: Move sja1105_change_tpid into sja1105_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31e5c5ab-7188-2ebb-d090-3e31f737adf5@gmail.com>
Date:   Tue, 4 Jun 2019 13:58:12 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, vivien.didelot@...il.com,
        andrew@...n.ch, davem@...emloft.net, richardcochran@...il.com,
        john.stultz@...aro.org, tglx@...utronix.de, sboyd@...nel.org
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 04/17] net: dsa: sja1105: Move
 sja1105_change_tpid into sja1105_vlan_filtering



On 6/4/2019 10:07 AM, Vladimir Oltean wrote:
> This is a cosmetic patch, pre-cursor to making another change to the
> General Parameters Table (incl_srcpt) which does not logically pertain
> to the sja1105_change_tpid function name, but not putting it there would
> otherwise create a need of resetting the switch twice.
> 
> So simply move the existing code into the .port_vlan_filtering callback,
> where the incl_srcpt change will be added as well.
> 
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian