linux-kernel - Re: [PATCH] driver core: show the error number when driver_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Jun 2019 14:37:34 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "Rafael J. Wysocki" <rafael@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] driver core: show the error number when
 driver_sysfs_add() fails


On 2019/6/4 13:33, Greg Kroah-Hartman wrote:
> On Tue, Jun 04, 2019 at 12:15:46PM +0800, Kefeng Wang wrote:
>> If driver_sysfs_add() fails, kernel shows following message,
>>
>>   really_probe: driver_sysfs_add(portman.0) failed
>>   ppdev: probe of portman.0 failed with error 0
>>
>> It's better to show the error number like other probe_failed path.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
>> ---
>>  drivers/base/dd.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
>> index 0df9b4461766..04ee4e196530 100644
>> --- a/drivers/base/dd.c
>> +++ b/drivers/base/dd.c
>> @@ -493,7 +493,8 @@ static int really_probe(struct device *dev, struct device_driver *drv)
>>  			goto probe_failed;
>>  	}
>>  
>> -	if (driver_sysfs_add(dev)) {
>> +	ret = driver_sysfs_add(dev);
>> +	if (ret) {
>>  		printk(KERN_ERR "%s: driver_sysfs_add(%s) failed\n",
>>  			__func__, dev_name(dev));
> Shouldn't this be where the error number is shown?  No need for all
> callers to also show the same thing.

Like the message shown as above,  there is a common path to show all the probe error info,

"ppdev: probe of portman.0 failed with error 0"

but the driver_sysfs_add() error handling won't fill with ret, so error '0' is shown.
after this patch,

 really_probe: driver_sysfs_add(portman.0) failed
 ppdev: probe of portman.0 failed with error -12

>
> thanks,
>
> greg k-h
>
> .
>