linux-kernel - Re: [PATCH 01/22] perf intel-pt: Fix itrace defaults for perf script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f73ed6e-7935-b325-14af-0b9e43144ed4@intel.com>
Date:   Tue, 4 Jun 2019 14:32:15 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/22] perf intel-pt: Fix itrace defaults for perf script

On 31/05/19 7:45 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, May 20, 2019 at 11:45:16AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Mon, May 20, 2019 at 02:37:07PM +0300, Adrian Hunter escreveu:
>>> Commit 4eb068157121 ("perf script: Make itrace script default to all
>>> calls") does not work because 'use_browser' is being used to determine
>>> whether to default to periodic sampling (i.e. better for perf report).
>>> The result is that nothing but CBR events display for perf script
>>> when no --itrace option is specified.
>>>
>>> Fix by using 'default_no_sample' and 'inject' instead.
>>
>> Applied 1-3 for now, concentrating on fixes, will process 4-22 later.
> 
> Tested the ones that affect sqlite databases an the GUI, all look good,
> added committer notes and text screenshots as committer notes, thanks!

Thanks for applying!  Are patches 11-22 in your tree?