linux-kernel - Re: [PATCH] arm64: dts: rockchip: fix isp iommu clocks and power domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5083973.35ftUdt9Su@phil>
Date:   Tue, 04 Jun 2019 15:37:12 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     Helen Koike <helen.koike@...labora.com>
Cc:     linux-rockchip@...ts.infradead.org, kernel@...labora.com,
        ezequiel@...labora.com, laurent.pinchart@...asonboard.com,
        manivannan.sadhasivam@...aro.org,
        linux-arm-kernel@...ts.infradead.org,
        Vicente Bergas <vicencb@...il.com>, devicetree@...r.kernel.org,
        Klaus Goger <klaus.goger@...obroma-systems.com>,
        linux-kernel@...r.kernel.org,
        Christoph Muellner <christoph.muellner@...obroma-systems.com>,
        Randy Li <ayaka@...lik.info>,
        Philipp Tomsich <philipp.tomsich@...obroma-systems.com>,
        Rob Herring <robh+dt@...nel.org>,
        Tony Xie <tony.xie@...k-chips.com>,
        Mark Rutland <mark.rutland@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Marc Zyngier <marc.zyngier@....com>,
        Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH] arm64: dts: rockchip: fix isp iommu clocks and power domain

Am Montag, 3. Juni 2019, 16:22:15 CEST schrieb Helen Koike:
> isp iommu requires wrapper variants of the clocks.
> noc variants are always on and using the wrapper variants will activate
> {A,H}CLK_ISP{0,1} due to the hierarchy.
> 
> Also add the respective power domain.
> 
> Refer:
>  RK3399 TRM v1.4 Fig. 2-4 RK3399 Clock Architecture Diagram
>  RK3399 TRM v1.4 Fig. 8-1 RK3399 Power Domain Partition
> 
> Signed-off-by: Helen Koike <helen.koike@...labora.com>

applied for 5.3 with the received Tested-tag and I also moved
parts of the comment into the commit message making it:

"isp iommu requires wrapper variants of the clocks.
noc variants are always on and using the wrapper variants will activate
{A,H}CLK_ISP{0,1} due to the hierarchy.

Tested using the pending isp patch set (which is not upstream
yet). Without this patch, streaming from the isp stalls.
    
Also add the respective power domain and remove the "disabled" status.
    
Refer:
 RK3399 TRM v1.4 Fig. 2-4 RK3399 Clock Architecture Diagram
 RK3399 TRM v1.4 Fig. 8-1 RK3399 Power Domain Partition"

Thanks
Heiko