linux-kernel - Re: [PATCH] cpupower : frequency-set -r option misses the last cpu in related cpu list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe31ff62-da28-3f32-5f9e-171e624213bf@kernel.org>
Date:   Tue, 4 Jun 2019 09:16:12 -0600
From:   shuah <shuah@...nel.org>
To:     Thomas Renninger <trenn@...e.de>, ego@...ux.vnet.ibm.com
Cc:     Abhishek Goel <huntbag@...ux.vnet.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        shuah <shuah@...nel.org>
Subject: Re: [PATCH] cpupower : frequency-set -r option misses the last cpu in
 related cpu list

On 5/29/19 8:21 AM, Thomas Renninger wrote:
> Hi,
> 
> On Wednesday, May 29, 2019 2:12:34 PM CEST Gautham R Shenoy wrote:
>> Hi Abhishek,
>>
>> On Wed, May 29, 2019 at 3:02 PM Abhishek Goel
> 
> ...
>   
>>>                                  bitmask_setbit(cpus_chosen, cpus->cpu);
>>>                                  cpus = cpus->next;
>>>                          
>>>                          }
>>>
>>> +                       /* Set the last cpu in related cpus list */
>>> +                       bitmask_setbit(cpus_chosen, cpus->cpu);
>>
>> Perhaps you could convert the while() loop to a do ..  while(). That
>> should will ensure
>> that we terminate the loop after setting the last valid CPU.
> 
> It would do exactly the same, right?
> IMHO it's not worth the extra hassle of resubmitting. Setting the last value
> outside a while loop is rather common.
> 
> I do not have a CPU with related cores at hand.
> If you tested this it would be nice to see this pushed:
> 
> Reviewed-by: Thomas Renninger <trenn@...e.de>
> 

Applied to 
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/ 
cpupower branch.

thanks,
-- Shuah