linux-kernel - Re: [PATCH net-next v4] hinic: add LRO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190604090841.00007d28@intel.com>
Date:   Tue, 4 Jun 2019 09:08:41 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Xue Chaojing <xuechaojing@...wei.com>
Cc:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <luoshaokai@...wei.com>,
        <cloud.wangxiaoyun@...wei.com>, <chiqijun@...wei.com>,
        <wulike1@...wei.com>
Subject: Re: [PATCH net-next v4] hinic: add LRO support

On Tue, 4 Jun 2019 01:16:08 +0000 Xue wrote:
> This patch adds LRO support for the HiNIC driver.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Xue Chaojing <xuechaojing@...wei.com>

Hm, you added my reviewed-by tag, but I didn't add it myself, I
only commented on your code.  This is a no-no. You don't add tags with
other people's names just because you think you can/should.

If someone EXPLICITLY says: "go ahead and add my reviewed-by after these
changes" then you can add it yourself.

Also, what did you change in v1:v4? There should be a summary somewhere
in the commit log (usually after a ---)

FWIW, I looked over the code and my concerns were addressed.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>