linux-kernel - Re: [PATCH v3 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f29edea9d7989152cec218df1c99db4830267b0.camel@kernel.crashing.org>
Date:   Thu, 06 Jun 2019 08:04:06 +1000
From:   Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:     Talel Shenhar <talel@...zon.com>, nicolas.ferre@...rochip.com,
        jason@...edaemon.net, marc.zyngier@....com, mark.rutland@....com,
        mchehab+samsung@...nel.org, robh+dt@...nel.org,
        davem@...emloft.net, shawn.lin@...k-chips.com, tglx@...utronix.de,
        devicetree@...r.kernel.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Cc:     dwmw@...zon.co.uk, jonnyc@...zon.com, hhhawa@...zon.com,
        ronenk@...zon.com, hanochu@...zon.com, barakw@...zon.com
Subject: Re: [PATCH v3 1/2] dt-bindings: interrupt-controller: Amazon's
 Annapurna Labs FIC

On Wed, 2019-06-05 at 17:59 +0300, Talel Shenhar wrote:
> 

 ../..

> +- compatible: should be "amazon,al-fic"
> +- reg: physical base address and size of the registers
> +- interrupt-controller: identifies the node as an interrupt controller
> +- #interrupt-cells: must be 2.
> +- interrupt-parent: specifies the parent interrupt controller.
> +- interrupts: describes which input line in the interrupt parent, this
> +  fic's output is connected to.
> +
> +Example:
> +
> +amazon_fic: interrupt-controller@...d8a8500 {
> +	compatible = "amazon,al-fic";
> +	interrupt-controller;
> +	#interrupt-cells = <1>;
                            ^ should be 2

> +	reg = <0x0 0xfd8a8500 0x0 0x1000>;
> +	interrupt-parent = <&gic>;
> +	interrupts = <GIC_SPI 0x0 IRQ_TYPE_LEVEL_HIGH>;
> +};