linux-kernel - Re: [PATCH] orangefs-debugfs: fix a missing-check bug in debug_string_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Jun 2019 08:32:43 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     Gen Zhang <blackgod016574@...il.com>, hubcap@...ibond.com,
        martin@...ibond.com
Cc:     devel@...ts.orangefs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] orangefs-debugfs: fix a missing-check bug in
 debug_string_to_mask()

On 30. 05. 19, 11:04, Gen Zhang wrote:
> In debug_string_to_mask(), 'strsep_fodder' is allocated by kstrdup().
> It returns NULL when fails. So 'strsep_fodder' should be checked.
> 
> Signed-off-by: Gen Zhang <blackgod016574.gmail>
> ---
> diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c
> index 87b1a6f..a9a9aac 100644
> --- a/fs/orangefs/orangefs-debugfs.c
> +++ b/fs/orangefs/orangefs-debugfs.c
> @@ -888,6 +888,8 @@ static void debug_string_to_mask(char *debug_string, void *mask, int type)
>  	char *unchecked_keyword;
>  	int i;
>  	char *strsep_fodder = kstrdup(debug_string, GFP_KERNEL);
> +	if (!strsep_fodder)
> +		return;
>  	char *original_pointer;

You should get a compiler error/warning about mixing declarations with code.

thanks,
-- 
js
suse labs