linux-kernel - Re: [PATCH v3 2/6] i2c: acpi: Use available IRQ helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190605082641.GM28362@ediswmail.ad.cirrus.com>
Date:   Wed, 5 Jun 2019 09:26:41 +0100
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     <wsa@...-dreams.de>, <mika.westerberg@...ux.intel.com>,
        <jarkko.nikula@...ux.intel.com>, <linux-i2c@...r.kernel.org>,
        <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <benjamin.tissoires@...hat.com>, <jbroadus@...il.com>,
        <patches@...nsource.cirrus.com>
Subject: Re: [PATCH v3 2/6] i2c: acpi: Use available IRQ helper functions

On Tue, Jun 04, 2019 at 08:00:52PM +0300, Andy Shevchenko wrote:
> On Tue, May 28, 2019 at 03:28:56PM +0100, Charles Keepax wrote:
> > Use the available IRQ helper functions, most of the functions have
> > additional helpful side affects like configuring the trigger type of the
> > IRQ.
> > 
> 
> You do here two things, i.e.
> - splitting out helper function
> - converting it to use helpers
> 
> I would split the patch to do exact these steps separately, e.g.:
> - splitting out to a local helper
> - replacing open coded stuff with existing helpers
> 

This can't really be done like this, the helper is called by
acpi_dev_get_resources and I need the acpi_resource from that to
call acpi_dev_resource_interrupt. I guess I could do a separate
patch to start using i2c_dev_irq_from_resource if that would be
preferrable? But I think the rest needs to stay together.

Thanks,
Charles