[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <E8EB9DF9-3684-4312-86E6-AA7BF38CF121@goldelico.com>
Date: Wed, 5 Jun 2019 10:31:22 +0200
From: "H. Nikolaus Schaller" <hns@...delico.com>
To: Sam Ravnborg <sam@...nborg.org>
Cc: Thierry Reding <thierry.reding@...il.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>, tomi.valkeinen@...com,
imirkin@...m.mit.edu, marek.belisko@...il.com,
letux-kernel@...nphoenux.org, linux-omap@...r.kernel.org,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 0/2] drm/panel-simple: Add panel parameters for ortustech-com37h3m05dtc/99dtc and sharp-lq070y3dg3b
Hi Sam,
> Am 05.06.2019 um 10:29 schrieb Sam Ravnborg <sam@...nborg.org>:
>
> Hi Nikolaus.
>
> Thanks for the new panel patches.
> On Wed, Jun 05, 2019 at 07:07:01AM +0200, H. Nikolaus Schaller wrote:
>> V2:
>> * fix typo in 99dtc panel compatible string (reported by imirkin@...m.mit.edu)
>>
>> V1:
>>
>> Since v5.2-rc1 OMAP is no longer using a special display driver architecture
>> for DPI panels, but uses the general drm/panel/panel-simple.
>>
>> So we finally can add SoC independent panel definitions for two panel models
>> which we already had worked on quite a while ago (before device tree was
>> introduced):
>>
>> https://patchwork.kernel.org/patch/2851295/
>>
>>
>>
>> H. Nikolaus Schaller (2):
>> drm/panel: simple: Add Sharp LQ070Y3DG3B panel support
>> drm/panel: simple: Add Ortustech COM37H3M panel support
>
> All three panels are missing binding documentation.
> Please submit binding documentation, in separate patches, with
> proper "dt-bindings: xxx" subjects.
> See Documentation/device-tree/bindings/submitting...
Ah, ok. Yes, will add to v3 asap.
>
> Patches not applied due to the missing docs.
> But the patches itself looked good.
> You have specified bus_flags etc, and added the
> new entries in correct alphabetical order etc.
>
> Sam
BR and thanks,
Nikolaus
Powered by blists - more mailing lists