lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 05 Jun 2019 02:01:07 -0700
From:   Joe Perches <joe@...ches.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        benniciemanuel78@...il.com
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lukas Wunner <lukas@...ner.de>,
        Sebastian Ott <sebott@...ux.ibm.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] pci: hotplug: ibmphp: Fix 'line over 80 characters'
 Warning

On Wed, 2019-06-05 at 11:41 +0300, Andy Shevchenko wrote:
> On Sun, Jun 2, 2019 at 7:25 PM Emanuel Bennici
> <benniciemanuel78@...il.com> wrote:
[]
> > +                               debug("%s - call process_changeinstatus for"
> > +                                     "slot[%d]\n", __func__, i);
> 
> Do not split string literals like this.

Especially because it's common to miss the
space required between words when the
compiler coalesces the string fragments.

Like here.

Powered by blists - more mailing lists