linux-kernel - Re: [PATCH -next] net: ethernet: mediatek: fix mtk_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1559726369.9003.4.camel@mtkswgap22>
Date:   Wed, 5 Jun 2019 17:19:29 +0800
From:   Sean Wang <sean.wang@...iatek.com>
To:     Randy Dunlap <rdunlap@...radead.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        "John Crispin" <blogic@...nwrt.org>,
        Felix Fietkau <nbd@...nwrt.org>,
        Nelson Chang <nelson.chang@...iatek.com>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH -next] net: ethernet: mediatek: fix mtk_eth_soc build
 errors & warnings

Hi Randy, 

Thanks for your help.  But it seems I've already made the same fixup for the problem in http://lists.infradead.org/pipermail/linux-mediatek/2019-June/020301.html
as soon as the kbuild test robot reported this.

	Sean

On Tue, 2019-06-04 at 22:52 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix build errors in Mediatek mtk_eth_soc driver.
> 
> It looks like these 3 source files were meant to be linked together
> since 2 of them are library-like functions,
> but they are currently being built as 3 loadable modules.
> 
> Fixes these build errors:
> 
>   WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/mediatek/mtk_eth_path.o
>   WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/mediatek/mtk_sgmii.o
>   ERROR: "mtk_sgmii_init" [drivers/net/ethernet/mediatek/mtk_eth_soc.ko] undefined!
>   ERROR: "mtk_setup_hw_path" [drivers/net/ethernet/mediatek/mtk_eth_soc.ko] undefined!
>   ERROR: "mtk_sgmii_setup_mode_force" [drivers/net/ethernet/mediatek/mtk_eth_soc.ko] undefined!
>   ERROR: "mtk_sgmii_setup_mode_an" [drivers/net/ethernet/mediatek/mtk_eth_soc.ko] undefined!
>   ERROR: "mtk_w32" [drivers/net/ethernet/mediatek/mtk_eth_path.ko] undefined!
>   ERROR: "mtk_r32" [drivers/net/ethernet/mediatek/mtk_eth_path.ko] undefined!
> 
> This changes the loadable module name from mtk_eth_soc to mtk_eth.
> I didn't see a way to leave it as mtk_eth_soc.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Sean Wang <sean.wang@...iatek.com>
> Cc: John Crispin <blogic@...nwrt.org>
> Cc: Felix Fietkau <nbd@...nwrt.org>
> Cc: Nelson Chang <nelson.chang@...iatek.com>
> ---
>  drivers/net/ethernet/mediatek/Makefile |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next-20190604.orig/drivers/net/ethernet/mediatek/Makefile
> +++ linux-next-20190604/drivers/net/ethernet/mediatek/Makefile
> @@ -3,5 +3,5 @@
>  # Makefile for the Mediatek SoCs built-in ethernet macs
>  #
>  
> -obj-$(CONFIG_NET_MEDIATEK_SOC)                 += mtk_eth_soc.o mtk_sgmii.o \
> -						  mtk_eth_path.o
> +obj-$(CONFIG_NET_MEDIATEK_SOC)                 += mtk_eth.o
> +mtk_eth-y := mtk_eth_soc.o mtk_sgmii.o mtk_eth_path.o
> 
>