linux-kernel - Re: [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1559730524.24019.11.camel@nxp.com>
Date:   Wed, 5 Jun 2019 02:25:02 +0000
From:   Robin Gong <yibin.gong@....com>
To:     "vkoul@...nel.org" <vkoul@...nel.org>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "festevam@...il.com" <festevam@...il.com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Subject: Re: [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610

On 二, 2019-06-04 at 18:03 +0530, Vinod Koul wrote:
> On 29-05-19, 17:08, yibin.gong@....com wrote:
> 
> > 
> > @@ -205,8 +228,9 @@ static int fsl_edma_probe(struct
> > platform_device *pdev)
> >  	if (!fsl_edma)
> >  		return -ENOMEM;
> >  
> > -	fsl_edma->version = v1;
> > -	fsl_edma->dmamux_nr = DMAMUX_NR;
> > +	fsl_edma->drvdata = drvdata;
> > +	fsl_edma->version = drvdata->version;
> > +	fsl_edma->dmamux_nr = drvdata->dmamuxs;
> And can we avoid the duplication here, you have version and dmamuxs
> represented in two places. But right now it looks logical so the
> removal
> should be done after this series
To avoid more code changes in other edma driver such as mcf-edma.c and
fsl-edma-common.c(replace all version/dmamux_nr with new
'drvdata'),meanwhile, no board to test mcf-edma so I keep
'version'/'dmamux' here in the last minute. But if you stick, I would
try to refine it in next version. 
>