linux-kernel - Re: [PATCH] seqlock: mark raw_read_seqcount and read_seqcount_retry as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190605115815.GG15030@fuggles.cambridge.arm.com>
Date:   Wed, 5 Jun 2019 12:58:15 +0100
From:   Will Deacon <will.deacon@....com>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     peterz@...radead.org, mingo@...hat.com, tglx@...utronix.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] seqlock: mark raw_read_seqcount and read_seqcount_retry
 as __always_inline

On Mon, Jun 03, 2019 at 11:10:08AM +0200, Anders Roxell wrote:
> If CONFIG_FUNCTION_GRAPH_TRACER is enabled function sched_clock() in
> kernel/time/sched_clock.c is marked as notrace. However, functions
> raw_read_seqcount and read_seqcount_retry are marked as inline. If
> CONFIG_OPTIMIZE_INLINING is set that will make the two functions
> tracable which they shouldn't.

Might be nice to elaborate a bit here on what goes from specifically for
seqlocks. I assume something ends up going recursive thanks to the tracing
code?

With that:

Acked-by: Will Deacon <will.deacon@....com>

Will