linux-kernel - Re: [PATCH 2/3] arm64: arch_timer: mark functions as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Jun 2019 13:23:15 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Will Deacon <will.deacon@....com>,
        Anders Roxell <anders.roxell@...aro.org>
Cc:     mark.rutland@....com, catalin.marinas@....com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        tglx@...utronix.de, mingo@...hat.com
Subject: Re: [PATCH 2/3] arm64: arch_timer: mark functions as __always_inline

On 05/06/2019 12:56, Will Deacon wrote:
> On Mon, Jun 03, 2019 at 11:14:02AM +0200, Anders Roxell wrote:
>> If CONFIG_FUNCTION_GRAPH_TRACER is enabled function
>> arch_counter_get_cntvct() is marked as notrace. However, function
>> __arch_counter_get_cntvct is marked as inline. If
>> CONFIG_OPTIMIZE_INLINING is set that will make the two functions
>> tracable which they shouldn't.
>>
>> Rework so that functions __arch_counter_get_* are marked with
>> __always_inline so they will be inlined even if CONFIG_OPTIMIZE_INLINING
>> is turned on.
>>
>> Fixes: 0ea415390cd3 ("clocksource/arm_arch_timer: Use arch_timer_read_counter to access stable counters")
>> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
>> ---
>>  arch/arm64/include/asm/arch_timer.h | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> I can pick this up if Marc is happy with it.

Yup, looks good to me. Please add my

Acked-by: Marc Zyngier <marc.zyngier@....com>

	M.
-- 
Jazz is not dead. It just smells funny...