linux-kernel - Re: too large sg segments with commit 09324d32d2a08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <alpine.LFD.2.21.1906051557060.2118@schleppi>
Date:   Wed, 5 Jun 2019 15:57:41 +0200 (CEST)
From:   Sebastian Ott <sebott@...ux.ibm.com>
To:     Christoph Hellwig <hch@....de>
cc:     Ming Lei <ming.lei@...hat.com>, Hannes Reinecke <hare@...e.com>,
        Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: too large sg segments with commit 09324d32d2a08

On Wed, 5 Jun 2019, Christoph Hellwig wrote:
> Actually, it looks like something completely general isn't
> easily doable, not without some major dma API work.  Here is what
> should fix nvme, but a few other drivers will need fixes as well:
> 
> ---
> From 745541130409bc837a3416300f529b16eded8513 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@....de>
> Date: Wed, 5 Jun 2019 14:55:26 +0200
> Subject: nvme-pci: don't limit DMA segement size
> 
> NVMe uses PRPs (or optionally unlimited SGLs) for data transfers and
> has no specific limit for a single DMA segement.  Limiting the size
> will cause problems because the block layer assumes PRP-ish devices
> using a virt boundary mask don't have a segment limit.  And while this
> is true, we also really need to tell the DMA mapping layer about it,
> otherwise dma-debug will trip over it.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> Reported-by: Sebastian Ott <sebott@...ux.ibm.com>

Works for me. Thanks!