lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 4 Jun 2019 17:19:28 -0700
From:   Brendan Higgins <>
To:     Stephen Boyd <>
Cc:     Frank Rowand <>,
        Greg KH <>,
        Josh Poimboeuf <>,
        Kees Cook <>,
        Kieran Bingham <>,
        Luis Chamberlain <>,
        Peter Zijlstra <>,
        Rob Herring <>, shuah <>,
        "Theodore Ts'o" <>,
        Masahiro Yamada <>,
        devicetree <>,
        dri-devel <>,,
        "open list:DOCUMENTATION" <>,,
        linux-kbuild <>,
        Linux Kernel Mailing List <>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        linux-nvdimm <>,,
        Sasha Levin <>,
        "Bird, Timothy" <>,
        Amir Goldstein <>,
        Dan Carpenter <>,
        Daniel Vetter <>, Jeff Dike <>,
        Joel Stanley <>,
        Julia Lawall <>,
        Kevin Hilman <>,
        Knut Omang <>,
        Logan Gunthorpe <>,
        Michael Ellerman <>,
        Petr Mladek <>,
        Randy Dunlap <>,
        Richard Weinberger <>,
        David Rientjes <>,
        Steven Rostedt <>,
Subject: Re: [PATCH v4 03/18] kunit: test: add string_stream a std::stream
 like string builder

On Fri, May 17, 2019 at 10:43 AM Stephen Boyd <> wrote:
> Quoting Brendan Higgins (2019-05-14 15:16:56)
> > A number of test features need to do pretty complicated string printing
> > where it may not be possible to rely on a single preallocated string
> > with parameters.
> >
> > So provide a library for constructing the string as you go similar to
> > C++'s std::string.
> >
> > Signed-off-by: Brendan Higgins <>
> > Reviewed-by: Greg Kroah-Hartman <>
> > Reviewed-by: Logan Gunthorpe <>
> Is there any reason why we can't use the seqfile API for this? These
> both share a similar goal, formatting strings into a buffer to be read
> later. Maybe some new APIs would be needed to extract the buffer
> differently, but I hope we could share the code.

I can see why you are asking. It seems as though they are trying to do
*similar* things, and it seems possible that we might be able to
extract some common functionality out of seq_file that could replace
this; however, it looks like it would be require a significant
refactoring of seq_file to separate out the file system specific bits
from the more general stringbuilder functionality.

In my opinion, a refactoring like this makes no sense in this
patchset; it probably belongs in its own patchset (preferably as a
follow on). I also am not sure if the FS people would appreciate
indirection that serves them no benefit, but I can ask if you like.

> If it can't be used, can you please add the reasoning to the commit text
> here?

Will do.


Powered by blists - more mailing lists