lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 5 Jun 2019 15:51:53 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     Suzuki K Poulose <suzuki.poulose@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andrew Lunn <andrew@...n.ch>,
        Andreas Noever <andreas.noever@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Corey Minyard <minyard@....org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        "David S. Miller" <davem@...emloft.net>,
        David Airlie <airlied@...ux.ie>,
        Felipe Balbi <balbi@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Hartmut Knaack <knaack.h@....de>,
        Heiko Stuebner <heiko@...ech.de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Jonathan Cameron <jic23@...nel.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Len Brown <lenb@...nel.org>, Mark Brown <broonie@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Michael Jamet <michael.jamet@...el.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Rob Herring <robh+dt@...nel.org>,
        Sebastian Ott <sebott@...ux.ibm.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Wolfram Sang <wsa@...-dreams.de>
Subject: RE: [PATCH 02/13] bus_find_device: Unify the match callback with
 class_find_device

> -----Original Message-----
> From: Suzuki K Poulose [mailto:suzuki.poulose@....com]
> Subject: [PATCH 02/13] bus_find_device: Unify the match callback with
> class_find_device
> 
> There is an arbitrary difference between the prototypes of
> bus_find_device() and class_find_device() preventing their callers
> from passing the same pair of data and match() arguments to both of
> them, which is the const qualifier used in the prototype of
> class_find_device().  If that qualifier is also used in the
> bus_find_device() prototype, it will be possible to pass the same
> match() callback function to both bus_find_device() and
> class_find_device(), which will allow some optimizations to be made in
> order to avoid code duplication going forward.  Also with that, constify
> the "data" parameter as it is passed as a const to the match function.
> 
> For this reason, change the prototype of bus_find_device() to match
> the prototype of class_find_device() and adjust its callers to use the
> const qualifier in accordance with the new prototype of it.
> 

Visorbus portion looks ok.

Acked-by: David Kershner <david.kershner@...sys.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (7882 bytes)

Powered by blists - more mailing lists