lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 5 Jun 2019 15:51:53 +0000
From:   "Kershner, David A" <>
To:     Suzuki K Poulose <>,
        "" <>
CC:     "" <>,
        "" <>,
        Alexander Shishkin <>,
        Andrew Lunn <>,
        Andreas Noever <>,
        Arnd Bergmann <>,
        Bjorn Helgaas <>,
        Corey Minyard <>,
        Christian Borntraeger <>,
        "David S. Miller" <>,
        David Airlie <>,
        Felipe Balbi <>,
        Frank Rowand <>,
        Grygorii Strashko <>,
        Harald Freudenberger <>,
        Hartmut Knaack <>,
        Heiko Stuebner <>,
        Jason Gunthorpe <>,
        Jonathan Cameron <>,
        "James E.J. Bottomley" <>,
        Len Brown <>, Mark Brown <>,
        Michael Ellerman <>,
        Michael Jamet <>,
        "Martin K. Petersen" <>,
        Peter Oberparleiter <>,
        Rob Herring <>,
        Sebastian Ott <>,
        Srinivas Kandagatla <>,
        Yehezkel Bernat <>,
        Wolfram Sang <>
Subject: RE: [PATCH 02/13] bus_find_device: Unify the match callback with

> -----Original Message-----
> From: Suzuki K Poulose []
> Subject: [PATCH 02/13] bus_find_device: Unify the match callback with
> class_find_device
> There is an arbitrary difference between the prototypes of
> bus_find_device() and class_find_device() preventing their callers
> from passing the same pair of data and match() arguments to both of
> them, which is the const qualifier used in the prototype of
> class_find_device().  If that qualifier is also used in the
> bus_find_device() prototype, it will be possible to pass the same
> match() callback function to both bus_find_device() and
> class_find_device(), which will allow some optimizations to be made in
> order to avoid code duplication going forward.  Also with that, constify
> the "data" parameter as it is passed as a const to the match function.
> For this reason, change the prototype of bus_find_device() to match
> the prototype of class_find_device() and adjust its callers to use the
> const qualifier in accordance with the new prototype of it.

Visorbus portion looks ok.

Acked-by: David Kershner <>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (7882 bytes)

Powered by blists - more mailing lists