linux-kernel - Re: [PATCH v3 2/2] power: supply: ucs1002: Add HWMON interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9d8b0c4-e9f4-5a92-3832-3449153f807d@ti.com>
Date:   Wed, 5 Jun 2019 12:26:02 -0400
From:   "Andrew F. Davis" <afd@...com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>,
        <linux-pm@...r.kernel.org>
CC:     Guenter Roeck <linux@...ck-us.net>,
        Chris Healy <cphealy@...il.com>,
        Cory Tusar <cory.tusar@....aero>,
        Lucas Stach <l.stach@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Sebastian Reichel <sre@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] power: supply: ucs1002: Add HWMON interface

On 6/5/19 3:23 AM, Andrey Smirnov wrote:
> Expose current sensors found on UCS1002 via HWMON.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> Cc: Chris Healy <cphealy@...il.com>
> Cc: Cory Tusar <cory.tusar@....aero>
> Cc: Lucas Stach <l.stach@...gutronix.de>
> Cc: Fabio Estevam <fabio.estevam@....com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> ---
>   drivers/power/supply/ucs1002_power.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/power/supply/ucs1002_power.c b/drivers/power/supply/ucs1002_power.c
> index 677f20a4d76f..a4b6b37549cf 100644
> --- a/drivers/power/supply/ucs1002_power.c
> +++ b/drivers/power/supply/ucs1002_power.c
> @@ -571,6 +571,12 @@ static int ucs1002_probe(struct i2c_client *client,
>   		return ret;
>   	}
>   
> +	ret = devm_power_supply_add_hwmon_sysfs(info->charger);

Could this be added to the core power supply framework on registering so 
all devices get this, vs each driver having to add this line?

Andrew

> +	if (ret) {
> +		dev_err(dev, "Failed to add hmwon attributes: %d\n", ret);
> +		return ret;
> +	}
> +
>   	ret = regmap_read(info->regmap, UCS1002_REG_PIN_STATUS, &regval);
>   	if (ret) {
>   		dev_err(dev, "Failed to read pin status: %d\n", ret);
>