lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 5 Jun 2019 12:42:27 -0400
From:   Johannes Weiner <>
To:     Roman Gushchin <>
Cc:     Andrew Morton <>,,,,
        Shakeel Butt <>,
        Vladimir Davydov <>,
        Waiman Long <>
Subject: Re: [PATCH v6 01/10] mm: add missing smp read barrier on getting
 memcg kmem_cache pointer

On Tue, Jun 04, 2019 at 07:44:45PM -0700, Roman Gushchin wrote:
> Johannes noticed that reading the memcg kmem_cache pointer in
> cache_from_memcg_idx() is performed using READ_ONCE() macro,
> which doesn't implement a SMP barrier, which is required
> by the logic.
> Add a proper smp_rmb() to be paired with smp_wmb() in
> memcg_create_kmem_cache().
> The same applies to memcg_create_kmem_cache() itself,
> which reads the same value without barriers and READ_ONCE().
> Suggested-by: Johannes Weiner <>
> Signed-off-by: Roman Gushchin <>

Acked-by: Johannes Weiner <>

Powered by blists - more mailing lists