linux-kernel - Re: [PATCH] staging: kpc2000: kpc_dma: fix symbol 'kpc_dma_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50bb1c8e-29fb-4d70-3c87-22235fc9d4fd@gmail.com>
Date:   Wed, 5 Jun 2019 18:56:11 +0200
From:   Valerio G <valerio.click@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: kpc2000: kpc_dma: fix symbol
 'kpc_dma_add_device' was not declared.

Hi,

Thanks for the feedback. I re-submitted the patch as v2.

best,
Valerio

Il 05/06/19 18:11, Greg KH ha scritto:
> On Wed, Jun 05, 2019 at 05:57:11PM +0200, Valerio Genovese wrote:
>> This was reported by sparse:
>> drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:39:7: warning: symbol 'kpc_dma_add_device
>> ' was not declared. Should it be static?
>>
>> Signed-off-by: Valerio Genovese <valerio.click@...il.com>
>> ---
>>  drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h
>> index ee47f43e71cf..19e88c3bc13f 100644
>> --- a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h
>> +++ b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h
>> @@ -56,6 +56,7 @@ struct dev_private_data {
>>  };
>>  
>>  struct kpc_dma_device *kpc_dma_lookup_device(int minor);
>> +void kpc_dma_add_device(struct kpc_dma_device *ldev);
>>  
>>  extern const struct file_operations  kpc_dma_fops;
>>  
> 
> This is not how you fix this issue.
> 
> Look at the warning given to you.  Think about your C programming
> knowledge and remember what the 'static' keyword is and does.
> 
> Then fix the issue properly.
> 
> thanks,
> 
> greg k-h
>