linux-kernel - Re: [PATCH 10/13] drivers: Introduce variants of class_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24e8617f-2e15-bb6c-a6bb-bc9e6b32aa56@arm.com>
Date:   Wed, 5 Jun 2019 19:13:19 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, rafael@...nel.org,
        a.zummo@...ertech.it, alex.aring@...il.com,
        alexander.shishkin@...ux.intel.com, alexandre.belloni@...tlin.com,
        andrew@...n.ch, arnd@...db.de, dmurphy@...com, davem@...emloft.net,
        f.fainelli@...il.com, freude@...ux.ibm.com,
        heikki.krogerus@...ux.intel.com, heiko.carstens@...ibm.com,
        hkallweit1@...il.com, jacek.anaszewski@...il.com, jslaby@...e.com,
        lgirdwood@...il.com, linux-leds@...r.kernel.org,
        linux-rtc@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-wpan@...r.kernel.org, broonie@...nel.org,
        mcoquelin.stm32@...il.com, pavel@....cz, peda@...ntia.se,
        stefan@...enfreihafen.org, tomas.winkler@...el.com,
        rafael.j.wysocki@...el.com
Subject: Re: [PATCH 10/13] drivers: Introduce variants of class_find_device()

Hi Greg,

On 06/05/2019 05:14 PM, Greg KH wrote:
> On Wed, Jun 05, 2019 at 04:13:47PM +0100, Suzuki K Poulose wrote:
>> +/**
>> + * class_find_device_by_devt : device iterator for locating a particular device
>> + * matching the device type.
>> + * @class: class type
>> + * @start: device to start search from
>> + * @devt: device type of the device to match.
>> + */
>> +static inline struct device *class_find_device_by_devt(struct class *class,
>> +						       struct device *start,
>> +						       dev_t devt)
>> +{
>> +	return class_find_device(class, start, &devt, device_match_devt);
>> +}
> 
> Still has the start parameter, despite the changelog saying it would not
> :(
> 

Well, I kept the start parameter just for the _devt variants, as
mentioned in the changelog:

" The new wrappers except the lookup by devt, drops the "start" device 
pointer as none of the existing users need it and the attributes are 
usually unique. The idea is to stop the proliferation of custom match.."

Somehow I thought the dev_t may be duplicate for devices, which is why
I didn't change that alone. But that was silly of me to ignore the minor
number part. I will respin it fixing that.

Suzuki