| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Jun 2019 22:46:22 +0200 From: "Enrico Weigelt, metux IT consult" <info@...ux.net> To: linux-kernel@...r.kernel.org Subject: [PATCH] scripts: coccinelle: add check for uncessary double unlikely() calls IS_ERR() and IS_ERR_OR_NULL()) already call unlikely(), therefore expressions like "(unlikely(IS_ERR(foo))" or "(!likely(IS_ERR(foo))" aren't needed. This patch adds a coccinelle script that checks for that. Signed-off-by: Enrico Weigelt <info@...ux.net> --- scripts/coccinelle/api/double_unlikely.cocci | 35 ++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 scripts/coccinelle/api/double_unlikely.cocci diff --git a/scripts/coccinelle/api/double_unlikely.cocci b/scripts/coccinelle/api/double_unlikely.cocci new file mode 100644 index 0000000..0b9bb3b --- /dev/null +++ b/scripts/coccinelle/api/double_unlikely.cocci @@ -0,0 +1,35 @@ +// SPDX-License-Identifier: GPL-2.0 +// +// find unncessary cases of unlikely(IS_ERR(foo)) +// IS_ERR() already calls unlikely() call +// +// Copyright (C) 2019 Enrico Weigelt, metux IT consult <info@...ux.net> +// +virtual patch +virtual context +virtual org +virtual report + +@@ +expression E; +@@ +- unlikely(IS_ERR(E)) ++ IS_ERR(E) + +@@ +expression E; +@@ +- unlikely(IS_ERR_OR_NULL(E)) ++ IS_ERR_OR_NULL(E) + +@@ +expression E; +@@ +- likely(!IS_ERR(E)) ++ !IS_ERR(E) + +@@ +expression E; +@@ +- likely(!IS_ERR_OR_NULL(E)) ++ !IS_ERR_OR_NULL(E) -- 1.9.1
Powered by blists - more mailing lists