linux-kernel - Re: [PATCH 5/7] media: cedrus: Don't set chroma size for scale & rotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 05 Jun 2019 23:08:07 +0200
From:   Paul Kocialkowski <paul.kocialkowski@...tlin.com>
To:     Jernej Skrabec <jernej.skrabec@...l.net>, maxime.ripard@...tlin.com
Cc:     wens@...e.org, mchehab@...nel.org, gregkh@...uxfoundation.org,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/7] media: cedrus: Don't set chroma size for scale &
 rotation

Hi,

Le jeudi 30 mai 2019 à 23:15 +0200, Jernej Skrabec a écrit :
> Scale and rotation are currently not implemented, so it makes no sense to
> set chroma size for it.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@...l.net>

Acked-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Cheers,

Paul

> ---
>  drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> index 9c5819def186..9de20ae47916 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> @@ -79,9 +79,6 @@ void cedrus_dst_format_set(struct cedrus_dev *dev,
>  		reg = VE_PRIMARY_OUT_FMT_NV12;
>  		cedrus_write(dev, VE_PRIMARY_OUT_FMT, reg);
>  
> -		reg = VE_CHROMA_BUF_LEN_SDRT(chroma_size / 2);
> -		cedrus_write(dev, VE_CHROMA_BUF_LEN, reg);
> -
>  		reg = chroma_size / 2;
>  		cedrus_write(dev, VE_PRIMARY_CHROMA_BUF_LEN, reg);
>