linux-kernel - Re: [PATCH] usb: hub: report failure to enumerate uevent to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6439.1559769583@warthog.procyon.org.uk>
Date:   Wed, 05 Jun 2019 22:19:43 +0100
From:   David Howells <dhowells@...hat.com>
To:     Eugeniu Rosca <erosca@...adit-jv.com>
CC:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alan Stern <stern@...land.harvard.edu>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Mathias Payer <mathias.payer@...elwelt.net>,
        Kento Kobayashi <Kento.A.Kobayashi@...y.com>,
        Hui Peng <benquike@...il.com>,
        Raul E Rangel <rrangel@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Jan-Marek Glogowski <glogow@...home.de>,
        Bin Liu <b-liu@...com>,
        Colin Ian King <colin.king@...onical.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Jon Flatley <jflat@...omium.org>,
        Mathieu Malaterre <malat@...ian.org>,
        Spyridon Papageorgiou <spapageorgiou@...adit-jv.com>,
        Joshua Frkuska <joshua_frkuska@...tor.com>,
        "George G . Davis" <george_davis@...tor.com>,
        yuichi.kusakabe@...so-ten.com, yohhei.fukui@...so-ten.com,
        natsumi.kamei@...so-ten.com, yasano@...adit-jv.com,
        sliu@...adit-jv.com, Eugeniu Rosca <roscaeugeniu@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] usb: hub: report failure to enumerate uevent to userspace

Eugeniu Rosca <erosca@...adit-jv.com> wrote:

>  - Looking at commit [4], it seems that the new "notifier" interface/api
>    forces userspace applications to link against -lkeyutils [5].

No.  The keyctl(2) syscall is implemented in -lkeyutils library, and not in
-lc.  That's all.  If you want to call KEYCTL_NOTIFY to watch a key or
keyring, you need it; not otherwise.

>    Assuming the latter is designed for ("Kernel key management") [6],
>    it may look like the keyutils library is being abused to handle
>    the "USB (or really any hardware events)". Do you really plan to
>    extend the scope of the library to handle these new tasks?

No.

That said, it's probably worth providing some userspace library to wrap the
ring management.

David