lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 5 Jun 2019 16:52:30 -0500
From:   Steve French <smfrench@...il.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        Kefeng Wang <wangkefeng.wang@...wei.com>
Subject: Re: [PATCH] fs: cifs: drop unneeded likely() call around IS_ERR()

This duplicates a patch submitted earlier by Kefeng Wang
<wangkefeng.wang@...wei.com> which I plan to merge later today into
cifs-2.6.git for-next

On Wed, Jun 5, 2019 at 4:14 PM Enrico Weigelt, metux IT consult
<info@...ux.net> wrote:
>
> From: Enrico Weigelt <info@...ux.net>
>
> IS_ERR() already calls unlikely(), so this extra unlikely() call
> around IS_ERR() is not needed.
>
> Signed-off-by: Enrico Weigelt <info@...ux.net>
> ---
>  fs/cifs/dfs_cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
> index e3e1c13..1692c0c 100644
> --- a/fs/cifs/dfs_cache.c
> +++ b/fs/cifs/dfs_cache.c
> @@ -492,7 +492,7 @@ static struct dfs_cache_entry *__find_cache_entry(unsigned int hash,
>  #ifdef CONFIG_CIFS_DEBUG2
>                         char *name = get_tgt_name(ce);
>
> -                       if (unlikely(IS_ERR(name))) {
> +                       if (IS_ERR(name)) {
>                                 rcu_read_unlock();
>                                 return ERR_CAST(name);
>                         }
> --
> 1.9.1
>


-- 
Thanks,

Steve

Powered by blists - more mailing lists