linux-kernel - Re: [PATCH] clk: armada-xp: Remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 06 Jun 2019 11:07:07 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Philippe Mazenauer <philippe.mazenauer@...look.de>
Cc:     Philippe Mazenauer <philippe.mazenauer@...look.de>,
        Michael Turquette <mturquette@...libre.com>,
        Gregory CLEMENT <gregory.clement@...tlin.com>,
        Yangtao Li <tiny.windzz@...il.com>,
        "open list:COMMON CLK FRAMEWORK" <linux-clk@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: armada-xp: Remove unused variables

Quoting Philippe Mazenauer (2019-05-21 01:58:41)
> Variables 'mv98dx3236_gating_desc' and 'mv98dx3236_coreclks' are
> declared static and initialized, but are not used in the file.
> 
> ../drivers/clk/mvebu/armada-xp.c:213:41: warning: ‘mv98dx3236_gating_desc’ defined but not used [-Wunused-const-variable=]
>  static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
>                                          ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/clk/mvebu/armada-xp.c:171:38: warning: ‘mv98dx3236_coreclks’ defined but not used [-Wunused-const-variable=]
>  static const struct coreclk_soc_desc mv98dx3236_coreclks = {
>                                       ^~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@...look.de>
> ---
>  drivers/clk/mvebu/armada-xp.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
> index fa1568279c23..2ae24a5debd0 100644
> --- a/drivers/clk/mvebu/armada-xp.c
> +++ b/drivers/clk/mvebu/armada-xp.c
> @@ -168,11 +168,6 @@ static const struct coreclk_soc_desc axp_coreclks = {
>         .num_ratios = ARRAY_SIZE(axp_coreclk_ratios),
>  };
>  
> -static const struct coreclk_soc_desc mv98dx3236_coreclks = {
> -       .get_tclk_freq = mv98dx3236_get_tclk_freq,
> -       .get_cpu_freq = mv98dx3236_get_cpu_freq,

These functions are unused after applying this patch. Can you resend by
test compiling the code?