linux-kernel - Re: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190606215130.okbvt2qsdolnjivh@kafai-mbp.dhcp.thefacebook.com>
Date:   Thu, 6 Jun 2019 21:51:32 +0000
From:   Martin Lau <kafai@...com>
To:     Roman Gushchin <guro@...com>
CC:     Daniel Borkmann <daniel@...earbox.net>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Kernel Team <Kernel-team@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Yonghong Song <yhs@...com>
Subject: Re: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use
 bpf_skb_cgroup_id() helper

On Thu, Jun 06, 2019 at 01:30:12PM -0700, Roman Gushchin wrote:
> Currently bpf_skb_cgroup_id() is not supported for CGROUP_SKB
> programs. An attempt to load such a program generates an error
> like this:
> 
>     libbpf:
>     0: (b7) r6 = 0
>     ...
>     9: (85) call bpf_skb_cgroup_id#79
>     unknown func bpf_skb_cgroup_id#79
> 
> There are no particular reasons for denying it, and we have some
> use cases where it might be useful.
> 
> So let's add it to the list of allowed helpers.
Acked-by: Martin KaFai Lau <kafai@...com>