linux-kernel - Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Jun 2019 23:24:39 -0700
From:   Bitan Biswas <bbiswas@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        <linux-i2c@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     Shardar Mohammed <smohammed@...dia.com>,
        Sowjanya Komatineni <skomatineni@...dia.com>,
        Mantravadi Karthik <mkarthik@...dia.com>
Subject: Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects



On 5/31/19 5:45 AM, Dmitry Osipenko wrote:
> 31.05.2019 12:04, Bitan Biswas пишет:
>>
>>
>> On 5/30/19 4:43 AM, Dmitry Osipenko wrote:
>>> 30.05.2019 14:36, Dmitry Osipenko пишет:
>>>> 30.05.2019 9:14, Bitan Biswas пишет:
>>>>> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
>>>>> except for BUG/BUG_ON checks
>>>>
>>>> Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire,
>>>> hence there is absolutely no good reason in making system unusable on a
>>>> software bug. BUG_ON may be more useful for development, but not for a
>>>> casual daily usage.
>> I shall update the patch to remove the BUG/BUG_ON calls.
> 
> Please replace them with WARN_ON_ONCE.
> 
Based on review of the BUG_ON some were found redundant calls and hence 
planned to be removed. Non-trivial BUG_ON planned to be replaced with 
WARN_ON_ONCE call.

-regards,
  Bitan