lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 6 Jun 2019 14:50:51 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Antoine Tenart <antoine.tenart@...tlin.com>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
        maxime.chevallier@...tlin.com, gregory.clement@...tlin.com,
        miquel.raynal@...tlin.com, nadavh@...vell.com, igall@...vell.com
Subject: Re: [PATCH 00/14] crypto: inside-secure - self-test fixes

On Mon, May 27, 2019 at 04:50:52PM +0200, Antoine Tenart wrote:
> Hello,
> 
> The crypto runtime self-tests were improved and thanks to this we
> spotted new issues within the Inside Secure SafeXcel cryptographic
> engine driver:
> - Intermediate IV were not retrieved from the hardware nor copied to the
>   quest IV buffer for cbc(aes/des).
> - HMAC updates wasn't supported.
> - We spotted issues with the use of the SG lists.
> - There was an issue with the use of result buffers.
> 
> The series fixes all those issues, and includes other small changes
> found while doing this work.
> 
> Thanks!
> Antoine
> 
> Antoine Tenart (14):
>   crypto: inside-secure - remove empty line
>   crypto: inside-secure - move comment
>   crypto: inside-secure - fix coding style for a condition
>   crypto: inside-secure - remove useless check
>   crypto: inside-secure - improve the result error format when displayed
>   crypto: inside-secure - change returned error when a descriptor
>     reports an error
>   crypto: inside-secure - enable context reuse
>   crypto: inside-secure - unify cache reset
>   crypto: inside-secure - fix zeroing of the request in ahash_exit_inv
>   crypto: inside-secure - fix queued len computation
>   crypto: inside-secure - implement IV retrieval
>   crypto: inside-secure - add support for HMAC updates
>   crypto: inside-secure - fix use of the SG list
>   crypto: inside-secure - do not rely on the hardware last bit for
>     result descriptors
> 
>  drivers/crypto/inside-secure/safexcel.c       |  13 +-
>  drivers/crypto/inside-secure/safexcel.h       |  17 ++-
>  .../crypto/inside-secure/safexcel_cipher.c    | 116 +++++++++++-------
>  drivers/crypto/inside-secure/safexcel_hash.c  |  92 ++++++++------
>  drivers/crypto/inside-secure/safexcel_ring.c  |   3 +
>  5 files changed, 157 insertions(+), 84 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Powered by blists - more mailing lists