linux-kernel - Re: [PATCH v2 -next] crypto: atmel-i2c - Fix build error while CRC16 set to m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Jun 2019 14:58:11 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     davem@...emloft.net, ard.biesheuvel@...aro.org,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v2 -next] crypto: atmel-i2c - Fix build error while CRC16
 set to m

On Fri, May 31, 2019 at 08:17:49PM +0800, YueHaibing wrote:
> If CRYPTO_DEV_ATMEL_ECC is set m, which select CRC16 to m,
> while CRYPTO_DEV_ATMEL_SHA204A is set to y, building fails.
> 
> drivers/crypto/atmel-i2c.o: In function 'atmel_i2c_checksum':
> atmel-i2c.c:(.text+0x16): undefined reference to 'crc16'
> 
> Add CRC16 dependency to CRYPTO_DEV_ATMEL_SHA204A
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: da001fb651b0 ("crypto: atmel-i2c - add support for SHA204A random number generator")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2：use 'select' instead of 'depends on'
> ---
>  drivers/crypto/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt