linux-kernel - Re: [PATCH -next] phy: ti: am654-serdes: Make serdes_am654

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Jun 2019 11:14:45 +0300
From:   Roger Quadros <rogerq@...com>
To:     Yue Haibing <yuehaibing@...wei.com>, <kishon@...com>
CC:     <linux-kernel@...r.kernel.org>, <hulkci@...wei.com>
Subject: Re: [PATCH -next] phy: ti: am654-serdes: Make serdes_am654_xlate()
 static


On 18/04/2019 16:36, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fix sparse warning:
> 
> drivers/phy/ti/phy-am654-serdes.c:250:12: warning:
>  symbol 'serdes_am654_xlate' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Roger Quadros <rogerq@...com>

> ---
>  drivers/phy/ti/phy-am654-serdes.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/ti/phy-am654-serdes.c b/drivers/phy/ti/phy-am654-serdes.c
> index d376920..f8edd08 100644
> --- a/drivers/phy/ti/phy-am654-serdes.c
> +++ b/drivers/phy/ti/phy-am654-serdes.c
> @@ -247,8 +247,8 @@ static void serdes_am654_release(struct phy *x)
>  	mux_control_deselect(phy->control);
>  }
>  
> -struct phy *serdes_am654_xlate(struct device *dev, struct of_phandle_args
> -				 *args)
> +static struct phy *serdes_am654_xlate(struct device *dev,
> +				      struct of_phandle_args *args)
>  {
>  	struct serdes_am654 *am654_phy;
>  	struct phy *phy;
> 

-- 
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki