linux-kernel - Re: [PATCH 02/13] bus_find_device: Unify the match callback with class_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 6 Jun 2019 10:01:30 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Suzuki K Poulose <suzuki.poulose@....com>,
        linux-kernel@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, rafael@...nel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andrew Lunn <andrew@...n.ch>,
        Andreas Noever <andreas.noever@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Corey Minyard <minyard@....org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        David Kershner <david.kershner@...sys.com>,
        "David S. Miller" <davem@...emloft.net>,
        David Airlie <airlied@...ux.ie>,
        Felipe Balbi <balbi@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Hartmut Knaack <knaack.h@....de>,
        Heiko Stuebner <heiko@...ech.de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Jonathan Cameron <jic23@...nel.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Len Brown <lenb@...nel.org>, Mark Brown <broonie@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Michael Jamet <michael.jamet@...el.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Rob Herring <robh+dt@...nel.org>,
        Sebastian Ott <sebott@...ux.ibm.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH 02/13] bus_find_device: Unify the match callback with
 class_find_device



On 05/06/2019 16:13, Suzuki K Poulose wrote:
> There is an arbitrary difference between the prototypes of
> bus_find_device() and class_find_device() preventing their callers
> from passing the same pair of data and match() arguments to both of
> them, which is the const qualifier used in the prototype of
> class_find_device().  If that qualifier is also used in the
> bus_find_device() prototype, it will be possible to pass the same
> match() callback function to both bus_find_device() and
> class_find_device(), which will allow some optimizations to be made in
> order to avoid code duplication going forward.  Also with that, constify
> the "data" parameter as it is passed as a const to the match function.
> 
> For this reason, change the prototype of bus_find_device() to match
> the prototype of class_find_device() and adjust its callers to use the
> const qualifier in accordance with the new prototype of it.
> 
> Cc: Alexander Shishkin<alexander.shishkin@...ux.intel.com>
> Cc: Andrew Lunn<andrew@...n.ch>
> Cc: Andreas Noever<andreas.noever@...il.com>
> Cc: Arnd Bergmann<arnd@...db.de>
> Cc: Bjorn Helgaas<bhelgaas@...gle.com>
> Cc: Corey Minyard<minyard@....org>
> Cc: Christian Borntraeger<borntraeger@...ibm.com>
> Cc: David Kershner<david.kershner@...sys.com>
> Cc: "David S. Miller"<davem@...emloft.net>
> Cc: David Airlie<airlied@...ux.ie>
> Cc: Felipe Balbi<balbi@...nel.org>
> Cc: Frank Rowand<frowand.list@...il.com>
> Cc: Grygorii Strashko<grygorii.strashko@...com>
> Cc: Harald Freudenberger<freude@...ux.ibm.com>
> Cc: Hartmut Knaack<knaack.h@....de>
> Cc: Heiko Stuebner<heiko@...ech.de>
> Cc: Jason Gunthorpe<jgg@...pe.ca>
> Cc: Jonathan Cameron<jic23@...nel.org>
> Cc: Jonathan Cameron<jic23@...nel.org>
> Cc: "James E.J. Bottomley"<jejb@...ux.ibm.com>
> Cc: Len Brown<lenb@...nel.org>
> Cc: Mark Brown<broonie@...nel.org>
> Cc: Michael Ellerman<mpe@...erman.id.au>
> Cc: Michael Jamet<michael.jamet@...el.com>
> Cc: "Martin K. Petersen"<martin.petersen@...cle.com>
> Cc: Peter Oberparleiter<oberpar@...ux.ibm.com>
> Cc: Rob Herring<robh+dt@...nel.org>
> Cc: Sebastian Ott<sebott@...ux.ibm.com>
> Cc: Srinivas Kandagatla<srinivas.kandagatla@...aro.org>
> Cc: Yehezkel Bernat<YehezkelShB@...il.com>
> Cc: Wolfram Sang<wsa@...-dreams.de>
> Cc:rafael@...nel.org
> Cc: Greg Kroah-Hartman<gregkh@...uxfoundation.org>
> Signed-off-by: Suzuki K Poulose<suzuki.poulose@....com>
> ---
>   arch/powerpc/platforms/pseries/ibmebus.c           | 4 ++--
>   drivers/acpi/acpi_lpss.c                           | 4 ++--
>   drivers/acpi/sleep.c                               | 2 +-
>   drivers/acpi/utils.c                               | 4 ++--
>   drivers/base/bus.c                                 | 6 +++---
>   drivers/base/devcon.c                              | 2 +-
>   drivers/char/ipmi/ipmi_si_platform.c               | 2 +-
>   drivers/firmware/efi/dev-path-parser.c             | 4 ++--
>   drivers/gpu/drm/drm_mipi_dsi.c                     | 2 +-
>   drivers/hwtracing/coresight/coresight.c            | 6 +++---
>   drivers/hwtracing/coresight/of_coresight.c         | 2 +-
>   drivers/hwtracing/intel_th/core.c                  | 5 ++---
>   drivers/i2c/i2c-core-acpi.c                        | 4 ++--
>   drivers/i2c/i2c-core-of.c                          | 4 ++--
>   drivers/iio/inkern.c                               | 2 +-
>   drivers/infiniband/hw/hns/hns_roce_hw_v1.c         | 2 +-
>   drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
>   drivers/net/ethernet/ti/cpsw-phy-sel.c             | 4 ++--
>   drivers/net/ethernet/ti/davinci_emac.c             | 2 +-
>   drivers/net/ethernet/toshiba/tc35815.c             | 4 ++--
>   drivers/nvmem/core.c                               | 2 +-


For NVMEM changes,

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>


--srini