linux-kernel - Re: [PATCH] scsi: libsas, lldds: Use dev_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Jun 2019 13:57:18 +0200
From:   Jinpu Wang <jinpu.wang@...ud.ionos.com>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     John Garry <john.garry@...wei.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        intel-linux-scu@...el.com, artur.paszkiewicz@...el.com,
        Jack Wang <jinpu.wang@...fitbricks.com>,
        lindar_liu <lindar_liu@...sh.com>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        linux-kernel@...r.kernel.org, Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH] scsi: libsas, lldds: Use dev_is_expander()

On Thu, Jun 6, 2019 at 3:35 AM Jason Yan <yanaijie@...wei.com> wrote:
>
>
>
> On 2019/6/6 0:12, John Garry wrote:
> > Many times in libsas, and in LLDDs which use libsas, the check for an
> > expander device is re-implemented or open coded.
> >
> > Use dev_is_expander() instead. We rename this from
> > sas_dev_type_is_expander() to not spill so many lines in referencing.
> >
> > Signed-off-by: John Garry<john.garry@...wei.com>
>
> Cannot agree more，
>
> Reviewed-by: Jason Yan <yanaijie@...wei.com>
>
Looks good, thanks Jason!

Reviewed-by: Jack Wang <jinpu.wang@...ud.ionos.com>