linux-kernel - Re: [PATCH 3/7] media: cedrus: Fix decoding for some H264 videos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Jun 2019 15:45:33 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jernej Škrabec <jernej.skrabec@...l.net>
Cc:     Maxime Ripard <maxime.ripard@...tlin.com>,
        devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, paul.kocialkowski@...tlin.com,
        wens@...e.org, mchehab@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [PATCH 3/7] media: cedrus: Fix decoding for some H264 videos

On Mon, Jun 03, 2019 at 05:37:17PM +0200, Jernej Škrabec wrote:
> Dne ponedeljek, 03. junij 2019 ob 13:55:36 CEST je Maxime Ripard napisal(a):
> > int current = 0;
> > 
> > while (current < num) {
> >     int tmp = min(num - current, 32);
> > 
> >     cedrus_write(dev, VE_H264_TRIGGER_TYPE, 0x3 | (current << 8))
                                                       ^^^^^^^
This should be "tmp << 8" instead of "current << 8" though.


> >     while (...)
> >        ...
> > 
> >     current += tmp;
> > }
> 

regards,
dan carpenter