linux-kernel - Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ce6c5322918828db16134b45d7b0d6b208f943d.camel@perches.com>
Date:   Thu, 06 Jun 2019 09:55:49 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jerome Glisse <jglisse@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>
Cc:     rcampbell@...dia.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, John Hubbard <jhubbard@...dia.com>,
        Ira Weiny <ira.weiny@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Arnd Bergmann <arnd@...db.de>,
        Balbir Singh <bsingharora@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Matthew Wilcox <willy@...radead.org>,
        Souptick Joarder <jrdr.linux@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

On Thu, 2019-06-06 at 11:52 -0400, Jerome Glisse wrote:
> On Thu, Jun 06, 2019 at 12:41:29PM -0300, Jason Gunthorpe wrote:
> > On Thu, Jun 06, 2019 at 10:27:43AM -0400, Jerome Glisse wrote:
> > > On Thu, Jun 06, 2019 at 11:16:44AM -0300, Jason Gunthorpe wrote:
> > > > On Mon, May 06, 2019 at 04:29:39PM -0700, rcampbell@...dia.com wrote:
> > > > > From: Ralph Campbell <rcampbell@...dia.com>
> > > > > 
> > > > > There are no functional changes, just some coding style clean ups and
> > > > > minor comment changes.
> > > > > 
> > > > > Signed-off-by: Ralph Campbell <rcampbell@...dia.com>
> > > > > Reviewed-by: Jérôme Glisse <jglisse@...hat.com>
> > > > > Cc: John Hubbard <jhubbard@...dia.com>
> > > > > Cc: Ira Weiny <ira.weiny@...el.com>
> > > > > Cc: Dan Williams <dan.j.williams@...el.com>
> > > > > Cc: Arnd Bergmann <arnd@...db.de>
> > > > > Cc: Balbir Singh <bsingharora@...il.com>
> > > > > Cc: Dan Carpenter <dan.carpenter@...cle.com>
> > > > > Cc: Matthew Wilcox <willy@...radead.org>
> > > > > Cc: Souptick Joarder <jrdr.linux@...il.com>
> > > > > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > > > >  include/linux/hmm.h | 71 +++++++++++++++++++++++----------------------
> > > > >  mm/hmm.c            | 51 ++++++++++++++++----------------
> > > > >  2 files changed, 62 insertions(+), 60 deletions(-)
> > > > 
> > > > Applied to hmm.git, thanks
> > > 
> > > 
> > > Can you hold off, i was already collecting patches and we will
> > > be stepping on each other toe ... for instance i had
> > 
> > I'd really rather not, I have a lot of work to do for this cycle and
> > this part needs to start to move forward now. I can't do everything
> > last minute, sorry.
> > 
> > The patches I picked up all look very safe to move ahead.
> 
> I want to post all the patch you need to apply soon, it is really
> painful because they are lot of different branches i have to work
> with if you start pulling patches that differ from the below branch
> then you are making thing ever more difficult for me.
> 
> If you hold of i will be posting all the patches in one big set so
> that you can apply all of them in one go and it will be a _lot_
> easier for me that way.

Easier for you is not necessarily easier for a community.
Publish early and often.