linux-kernel - Re: [PATCH] clk: qcom: clk-rpm: Removed unused macros/variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190606173231.C64192083D@mail.kernel.org>
Date:   Thu, 06 Jun 2019 10:32:30 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Philippe Mazenauer <philippe.mazenauer@...look.de>
Cc:     Philippe Mazenauer <philippe.mazenauer@...look.de>,
        Andy Gross <agross@...nel.org>,
        David Brown <david.brown@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        "open list:COMMON CLK FRAMEWORK" <linux-clk@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: qcom: clk-rpm: Removed unused macros/variable

Quoting Philippe Mazenauer (2019-05-21 02:45:25)
> Removed macros DEFINE_CLK_RPM_PXO_BRANCH, DEFINE_CLK_RPM_CXO_BRANCH and
> variable 'clk_rpm_branch_ops'. The macros and variable are not used in the
> file.
> 
> As the variable, which is used by the macros, is declared static, the
> macros can't be used outside the file, are unused.
> 
> ../drivers/clk/qcom/clk-rpm.c:461:29: warning: ‘clk_rpm_branch_ops’ defined but not used [-Wunused-const-variable=]
>  static const struct clk_ops clk_rpm_branch_ops = {
>                              ^~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@...look.de>

Yeah it's dead code but the qcom folks wanted to manage the crystal with
this code so maybe we should just leave it around for them. Or they
could dig it out of the git history.