[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 06 Jun 2019 10:36:21 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: tanhuazhong@...wei.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
salil.mehta@...wei.com, yisen.zhuang@...wei.com,
linuxarm@...wei.com, tanxiaofei@...wei.com
Subject: Re: [PATCH net-next 01/12] net: hns3: log detail error info of
ROCEE ECC and AXI errors
From: Huazhong Tan <tanhuazhong@...wei.com>
Date: Thu, 6 Jun 2019 16:20:56 +0800
> +static int hclge_log_rocee_axi_error(struct hclge_dev *hdev)
> +{
...
> + ret = hclge_cmd_send(&hdev->hw, &desc[0], 3);
> + if (ret) {
> + dev_err(dev, "failed(%d) to query ROCEE AXI error sts\n", ret);
> + return ret;
> + }
...
> + ret = hclge_log_rocee_axi_error(hdev);
> + if (ret) {
> + dev_err(dev, "failed(%d) to process axi error\n", ret);
You log the error twice which is unnecessary.
Powered by blists - more mailing lists