linux-kernel - Re: [PATCH 1/2] aio: simplify the usage of restore_saved_sigmask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wgDgKA52SpzrW_dy76Jx6qxE393xzhiyQQ+rtic399PYw@mail.gmail.com>
Date:   Fri, 7 Jun 2019 11:09:39 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Oleg Nesterov <oleg@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Benjamin LaHaise <bcrl@...ck.org>,
        Arnd Bergmann <arnd@...db.de>,
        David Laight <David.Laight@...lab.com>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Eric Wong <e@...24.org>, linux-aio@...ck.org,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] aio: simplify the usage of restore_saved_sigmask_unless()

On Fri, Jun 7, 2019 at 11:03 AM Eric W. Biederman <ebiederm@...ssion.com> wrote:
>
> Unless I am misreading things io_pgetevents isn't restartable
> either and ERESTARTNOHAND is a bug in that case.
>
> Is the bug going the other way?

Yeah, I think you're right, and that should be EINTR too.

Or at least be conditional on whether it had a timeout or not. A NULL
timeout obviously _is_ restartable. But I don't think it's worth being
clever here.

                Linus