linux-kernel - Re: [PATCH] perf config: Update default value for llvm.clang-bpf-cmd-template

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190607183254.GM21245@kernel.org>
Date:   Fri, 7 Jun 2019 15:32:54 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Leo Yan <leo.yan@...aro.org>
Cc:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andi Kleen <ak@...ux.intel.com>, Mark Drayton <mbd@...com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH] perf config: Update default value for
 llvm.clang-bpf-cmd-template

Em Fri, Jun 07, 2019 at 10:35:08PM +0800, Leo Yan escreveu:
> The clang bpf cmdline template has defined default value in the file
> tools/perf/util/llvm-utils.c, which has been changed for several times.
> 
> This patch updates the documentation to reflect the latest default value
> for the configuration llvm.clang-bpf-cmd-template.
> 
> Fixes: d35b168c3dcd ("perf bpf: Give precedence to bpf header dir")
> Fixes: cb76371441d0 ("perf llvm: Allow passing options to llc in addition to clang")
> Fixes: 1b16fffa389d ("perf llvm-utils: Add bpf include path to clang command line")

Well done! Three fixes! :-)

Who was it that made the changes and forgot to update the docs... oops,
it was me 8-)

Thanks, applied.

- Arnaldo


> Signed-off-by: Leo Yan <leo.yan@...aro.org>
> ---
>  tools/perf/Documentation/perf-config.txt | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Documentation/perf-config.txt
> index 462b3cde0675..e4aa268d2e38 100644
> --- a/tools/perf/Documentation/perf-config.txt
> +++ b/tools/perf/Documentation/perf-config.txt
> @@ -564,9 +564,12 @@ llvm.*::
>  	llvm.clang-bpf-cmd-template::
>  		Cmdline template. Below lines show its default value. Environment
>  		variable is used to pass options.
> -		"$CLANG_EXEC -D__KERNEL__ $CLANG_OPTIONS $KERNEL_INC_OPTIONS \
> -		-Wno-unused-value -Wno-pointer-sign -working-directory \
> -		$WORKING_DIR  -c $CLANG_SOURCE -target bpf -O2 -o -"
> +		"$CLANG_EXEC -D__KERNEL__ -D__NR_CPUS__=$NR_CPUS "\
> +		"-DLINUX_VERSION_CODE=$LINUX_VERSION_CODE "	\
> +		"$CLANG_OPTIONS $PERF_BPF_INC_OPTIONS $KERNEL_INC_OPTIONS " \
> +		"-Wno-unused-value -Wno-pointer-sign "		\
> +		"-working-directory $WORKING_DIR "		\
> +		"-c \"$CLANG_SOURCE\" -target bpf $CLANG_EMIT_LLVM -O2 -o - $LLVM_OPTIONS_PIPE"
>  
>  	llvm.clang-opt::
>  		Options passed to clang.
> -- 
> 2.17.1

-- 

- Arnaldo