linux-kernel - Re: [PATCH V5] drivers: i2c: tegra: fix warning/check/error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190607060358.GB1035@kunai>
Date:   Fri, 7 Jun 2019 08:03:59 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Bitan Biswas <bbiswas@...dia.com>
Cc:     Laxman Dewangan <ldewangan@...dia.com>,
        Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-i2c@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shardar Mohammed <smohammed@...dia.com>,
        Sowjanya Komatineni <skomatineni@...dia.com>,
        Mantravadi Karthik <mkarthik@...dia.com>
Subject: Re: [PATCH V5] drivers: i2c: tegra: fix warning/check/error

On Thu, Jun 06, 2019 at 10:25:03PM -0700, Bitan Biswas wrote:
> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
> 
> Ignore checkpatch WARNING for 80 character line limit at
> places where renaming fields compromises readability.
> 
> Delay of approximately 1msec in flush i2c FIFO polling loop
> achieved by usleep_range call as msleep can take 20msecs.
> 
> Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
> as needed. Replace BUG() with error handling code.
> Define I2C_ERR_UNEXPECTED_STATUS for error handling.

You removed the word checkpatch from $subject, but you still did not
split up the patch into logical pieces. The description above already
outlines what those logical pieces could be.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)