linux-kernel - Re: [alsa-devel] next/master boot bisection: next-20190528 on sun8i-h3-libretech-all-h3-cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6959db6d-1ab4-8f94-7e58-57606b8b42f6@linux.intel.com>
Date:   Fri, 7 Jun 2019 15:08:45 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Mark Brown <broonie@...nel.org>,
        Guillaume Tucker <guillaume.tucker@...labora.com>
Cc:     Takashi Iwai <tiwai@...e.de>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        tomeu.vizoso@...labora.com, mgalka@...labora.com,
        matthew.hart@...aro.org, khilman@...libre.com,
        enric.balletbo@...labora.com, Liam Girdwood <lgirdwood@...il.com>,
        alsa-devel@...a-project.org, "kernelci.org bot" <bot@...nelci.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] next/master boot bisection: next-20190528 on
 sun8i-h3-libretech-all-h3-cc



On 6/7/19 2:00 PM, Mark Brown wrote:
> On Fri, Jun 07, 2019 at 05:31:12PM +0100, Guillaume Tucker wrote:
>> On 30/05/2019 16:53, Takashi Iwai wrote:
> 
>>>> +	mutex_lock(&client_mutex);
>>>>   	for_each_rtdcom(rtd, rtdcom) {
>>>>   		component = rtdcom->component;
>>>>   
>>>>   		if (component->driver->remove_order == order)
>>>>   			soc_remove_component(component);
>>>>   	}
>>>> +	mutex_unlock(&client_mutex);
> 
>>> Ranjani, which code path your patch tries to address?  Maybe better to
>>> wrap client_mutex() in the caller side like snd_soc_unbind_card()?
> 
>> Is anyone looking into this issue?
> 
>> It is still occurring in next-20190606, there was a bisection
>> today which landed on the same commit.  There just hasn't been
>> any new bisection reports because they have been temporarily
>> disabled while we fix some issues on kernelci.org.
> 
> I was expecting that Ranjani or one of the other Intel people was
> looking into it...

Ack. We've all been underwater this week and this wasn't addressed, 
sorry about the delay. It's probably wise to revert this commit at this 
point while we look for an alternate solution?

There was an initial proposal submitted on GitHub [1] (patch attached) 
which implemented what Takashi suggested in his comments. This proposal 
was later optimized further, it could be that the optimization was one 
bridge too far.

Could you let us know if this attached patch has any negative effects on 
non-Intel platforms?

Thanks!

[1] 
https://github.com/thesofproject/linux/commit/9fd09dd417bc8be7a4a8bdd1621558151f8d117b

View attachment "9fd09dd417bc8be7a4a8bdd1621558151f8d117b.patch" of type "text/x-patch" (1230 bytes)