linux-kernel - Re: [PATCH v3 0/5] arch: riscv: add board and SoC DT file support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2edcc269fece4110d2629968c31867ff659e3285.camel@aisec.fraunhofer.de>
Date:   Fri, 7 Jun 2019 20:55:07 +0000
From:   "Auer, Lukas" <lukas.auer@...ec.fraunhofer.de>
To:     "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "atish.patra@....com" <atish.patra@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "khilman@...libre.com" <khilman@...libre.com>
Subject: Re: [PATCH v3 0/5] arch: riscv: add board and SoC DT file support

On Fri, 2019-06-07 at 10:58 -0700, Atish Patra wrote:
> On 6/7/19 9:52 AM, Kevin Hilman wrote:
> > Atish Patra <atish.patra@....com> writes:
> > 
> > > On 6/5/19 10:37 AM, Kevin Hilman wrote:
> > > > Hi Paul,
> > > > 
> > > > Paul Walmsley <paul.walmsley@...ive.com> writes:
> > > > 
> > > > > Add support for building flattened DT files from DT source files under
> > > > > arch/riscv/boot/dts.  Follow existing kernel precedent from other SoC
> > > > > architectures.  Start our board support by adding initial support for
> > > > > the SiFive FU540 SoC and the first development board that uses it, the
> > > > > SiFive HiFive Unleashed A00.
> > > > > 
> > > > > This third version of the patch set adds I2C data for the chip,
> > > > > incorporates all remaining changes that riscv-pk was making
> > > > > automatically, and addresses a comment from Rob Herring
> > > > > <robh@...nel.org>.
> > > > > 
> > > > > Boot-tested on v5.2-rc1 on a HiFive Unleashed A00 board, using the
> > > > > BBL and open-source FSBL, with modifications to pass in the DTB
> > > > > file generated by these patches.
> > > > 
> > > > Tested this series on top of v5.2-rc3 on HiFive Unleashed board using
> > > > OpenSBI + mainline u-boot (master branch as of today).
> > > > 
> > > > Tested-by: Kevin Hilman <khilman@...libre.com>
> > > > 
> > > > > This patch series can be found, along with the PRCI patch set
> > > > > and the DT macro prerequisite patch, at:
> > > > > 
> > > > > https://github.com/sifive/riscv-linux/tree/dev/paulw/dts-v5.2-rc1
> > > > 
> > > > nit: I only see this series in that branch, not any of the prerequisite
> > > > patches you mentioned, which made me assume I could this series alone on
> > > > top of v5.2-rc3, which worked just fine.
> > > > 
> > > 
> > > I tried only this series on top of v5.2-rc3. Kernel boots file with DT
> > > updated via U-Boot. But networking didn't come up.
> > > 
> > > Do you have networking up after the boot? If yes, can you please share
> > > the config.
> > 
> > I didn't test networking from the kernel initially, but looking now, I
> > do not have networking come up in the kernel either.
> > 
> 
> ok. I am not alone then :).
> 
> @Paul: Do you get networking up in your FSBL + BBL + Linux boot flow 
> with the DT patch series ?
> 

There does not appear to be a device tree node for the ethernet
controller, which would be why networking is not coming up. U-Boot also
has to be updated to match the new device bindings introduced by the
ethernet controller patches currently on the mailing list [1].

Thanks,
Lukas

[1]: 
https://patchwork.kernel.org/project/linux-riscv/list/?series=121579