linux-kernel - Re: [PATCH 3/4] Documentation: x86: Clarify MBA takes MB as referring to mba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Jun 2019 14:28:10 -0700
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     James Morse <james.morse@....com>
Cc:     linux-doc@...r.kernel.org, x86@...nel.org,
        Jonathan Corbet <corbet@....net>,
        Reinette Chatre <reinette.chatre@...el.com>,
        Babu Moger <Babu.Moger@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Documentation: x86: Clarify MBA takes MB as
 referring to mba_sc

On Fri, Jun 07, 2019 at 04:14:08PM +0100, James Morse wrote:
> "If the MBA is specified in MB then user can enter the max b/w in MB"
> is a tautology. How can the user know if the schemata takes a percentage
> or a MB/s value?
> 
> This is referring to whether the software controller is interpreting
> the schemata's value. Make this clear.
> 
> Signed-off-by: James Morse <james.morse@....com>
> ---
>  Documentation/x86/resctrl_ui.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/x86/resctrl_ui.rst b/Documentation/x86/resctrl_ui.rst
> index 638cd987937d..866b66aa289b 100644
> --- a/Documentation/x86/resctrl_ui.rst
> +++ b/Documentation/x86/resctrl_ui.rst
> @@ -677,8 +677,8 @@ allocations can overlap or not. The allocations specifies the maximum
>  b/w that the group may be able to use and the system admin can configure
>  the b/w accordingly.
>  
> -If the MBA is specified in MB(megabytes) then user can enter the max b/w in MB
> -rather than the percentage values.
> +If resctrl is using the software controller (mba_sc) then user can enter the
> +max b/w in MB rather than the percentage values.
>  ::
>  
>    # echo "L3:0=3;1=c\nMB:0=1024;1=500" > /sys/fs/resctrl/p0/schemata
> -- 
> 2.20.1
> 

Acked-by: Fenghua Yu <fenghua.yu@...el.com>

Thanks.

-Fenghua